Re: [Qemu-devel] [PATCH v4 02/29] target-ppc: Merge 970FX and 970MP into a single 970 class

[Alexey Kardashevskiy]

On 06/04/2014 02:25 AM, Tom Musta wrote:
> On 6/3/2014 4:27 AM, Alexey Kardashevskiy wrote:
>> @@ -7303,8 +7304,21 @@ static void init_proc_970 (CPUPPCState *env)
>>                   SPR_NOACCESS, SPR_NOACCESS,
>>                   &spr_read_hior, &spr_write_hior,
>>                   0x00000000);
>> +
>> +    spr_register(env, SPR_CTRL, "SPR_CTRL",
>> +                 SPR_NOACCESS, SPR_NOACCESS,
>> +                 SPR_NOACCESS, &spr_write_generic,
>> +                 0x00000000);
>> +    spr_register(env, SPR_UCTRL, "SPR_UCTRL",
>> +                 SPR_NOACCESS, SPR_NOACCESS,
>> +                 &spr_read_generic, SPR_NOACCESS,
>> +                 0x00000000);
> 
> This doesn't look quite right .... UCTRL is readable also from both user & 
> supervisor mode.
> 
> And UCTRL should alias CTRL (a la your read_ureg helper).
> 
> But you've only re-arranged existing code ... not regressed anything.  This 
> should be fixed in
> a follow up patch.


I will add it as a separate patch in v5.


-- 
Alexey