Re: [Qemu-devel] [PATCH 1/3] nbd: Handle fixed new-style clients.

[Stefan Hajnoczi]

On Mon, Jun 02, 2014 at 11:09:02PM +0100, Hani Benhabiles wrote:
> On Mon, Jun 02, 2014 at 02:32:06PM +0200, Stefan Hajnoczi wrote:
> > On Sat, May 31, 2014 at 10:39:40PM +0100, Hani Benhabiles wrote:
> > > Signed-off-by: Hani Benhabiles <address@hidden>
> > > ---
> > >  include/block/nbd.h |  6 ++++++
> > >  nbd.c               | 12 +++++++-----
> > >  2 files changed, 13 insertions(+), 5 deletions(-)
> > 
> > No explanation or link to specification for this new flag field?  What's
> > different about a new-style client?
> 
> With this flag is set, the server tells the client that it can send another
> option if the server got a request with an option it doesn't understand 
> (instead
> of the server closing the connection.) Thus, the while(1) loop in 2/3.

Great, please include this explanation in the commit description.

> The kernel in Documentation/blockdev/nbd.txt points to the NBD project for
> documentation. The proto documentation is in [1]. Shouldn't Qemu also do the
> same ?
> 
> [1] https://github.com/yoe/nbd/blob/master/doc/proto.txt

Please add the link as a comment to the top of nbd.c.

Stefan