qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with Qemu


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts
Date: Wed, 4 Jun 2014 11:18:24 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

On Wed, May 07, 2014 at 05:58:25PM +0800, Chunyan Liu wrote:
> This patch series is to replace QEMUOptionParameter with QemuOpts, so that 
> only
> one Qemu Option structure is kept in QEMU code.
> 
> ---
> Changes to v26:
>   * Following Eric's comment, backward split 2/33, 3/33.
>     (repurpose qemu_opts_print first, add def_value_str to QemuOptDesc later).
>   * Fix memory free in qemu_opts_append to solve iotest issue. 10/33
>   * Following Eric's comment, remove the end '.' in error message. And update
>     qemu-iotests .out file. 12/33
>   * Following Eric's comment, fix memory free in vvfat.c 13/33
>   * Following Eric's comment, split qcow2 patch into two. 19/33, 20/33:
>     export qemu_opt_find first, add qcow2 driver patch later.
>   * rebase to git master
> 
> All patches are also available from:
> https://github.com/chunyanliu/qemu/commits/QemuOpts

Please git rebase -x 'make && make check && make check-block' -i master:

qemu-img.c: In function ‘print_block_option_help’:
qemu-img.c:289:36: error: ‘create_options’ undeclared (first use in this
function)
             free_option_parameters(create_options);
                                                 ^



reply via email to

[Prev in Thread] Current Thread [Next in Thread]