Re: [Qemu-devel] [PATCH] target-arm: Delete unused iwmmxt_msadb helper

[Peter Crosthwaite]

On Wed, Jun 4, 2014 at 5:02 AM, Peter Maydell <address@hidden> wrote:
> The iwmmxt_msadb helper and its corresponding gen function are unused;
> delete them. (This function appears to have never been used right back
> to the initial implementation of iwMMXt; it is identical to iwmmxt_madduq,
> and is presumably an accidental remnant from the initial development.)
>
> Signed-off-by: Peter Maydell <address@hidden>

Reviewed-by: Peter Crosthwaite <address@hidden>

> ---
> More dead code elimination courtesy of clang 3.4...
>
>  target-arm/helper.h        | 2 --
>  target-arm/iwmmxt_helper.c | 9 ---------
>  target-arm/translate.c     | 2 --
>  3 files changed, 13 deletions(-)
>
> diff --git a/target-arm/helper.h b/target-arm/helper.h
> index b63fd0f..393ef4d 100644
> --- a/target-arm/helper.h
> +++ b/target-arm/helper.h
> @@ -456,8 +456,6 @@ DEF_HELPER_3(iwmmxt_avgb1, i64, env, i64, i64)
>  DEF_HELPER_3(iwmmxt_avgw0, i64, env, i64, i64)
>  DEF_HELPER_3(iwmmxt_avgw1, i64, env, i64, i64)
>
> -DEF_HELPER_2(iwmmxt_msadb, i64, i64, i64)
> -
>  DEF_HELPER_3(iwmmxt_align, i64, i64, i64, i32)
>  DEF_HELPER_4(iwmmxt_insr, i64, i64, i32, i32, i32)
>
> diff --git a/target-arm/iwmmxt_helper.c b/target-arm/iwmmxt_helper.c
> index 398cbcb..a506914 100644
> --- a/target-arm/iwmmxt_helper.c
> +++ b/target-arm/iwmmxt_helper.c
> @@ -369,15 +369,6 @@ IWMMXT_OP_AVGW(1)
>  #undef IWMMXT_OP_AVGW
>  #undef AVGW
>
> -uint64_t HELPER(iwmmxt_msadb)(uint64_t a, uint64_t b)
> -{
> -    a =  ((((a >> 0 ) & 0xffff) * ((b >> 0) & 0xffff) +
> -           ((a >> 16) & 0xffff) * ((b >> 16) & 0xffff)) & 0xffffffff) |
> -         ((((a >> 32) & 0xffff) * ((b >> 32) & 0xffff) +
> -           ((a >> 48) & 0xffff) * ((b >> 48) & 0xffff)) << 32);
> -    return a;
> -}
> -
>  uint64_t HELPER(iwmmxt_align)(uint64_t a, uint64_t b, uint32_t n)
>  {
>      a >>= n << 3;
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 7f6fcd6..37d3b6b 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -1381,8 +1381,6 @@ IWMMXT_OP_ENV(avgb1)
>  IWMMXT_OP_ENV(avgw0)
>  IWMMXT_OP_ENV(avgw1)
>
> -IWMMXT_OP(msadb)
> -
>  IWMMXT_OP_ENV(packuw)
>  IWMMXT_OP_ENV(packul)
>  IWMMXT_OP_ENV(packuq)
> --
> 1.9.2
>
>