[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bsd-user/mmap.c: Don't try to override g_malloc
|
From: |
Ed Maste |
|
Subject: |
Re: [Qemu-devel] [PATCH] bsd-user/mmap.c: Don't try to override g_malloc/g_free |
|
Date: |
Wed, 4 Jun 2014 14:40:09 -0400 |
On 3 June 2014 19:51, Peter Maydell <address@hidden> wrote:
> Trying to override the implementations of g_malloc and g_free is
> a really bad idea -- it means statically linked builds fail to
> link (because of the multiple definitions provided by this file
> and by glib), and non-statically linked builds segfault as soon
> as they try to do anything more complicated than printing the
> usage message. Remove these overridden versions and just use
> the glib ones.
>
> This is sufficient that bsd-user can run basic x86-64
> binaries on OpenBSD again; FreeBSD and NetBSD seem to have
> further issues.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Ed Maste <address@hidden>