[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] PPC: e500: Merge 32 and 64 bit SPE emulatio
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] PPC: e500: Merge 32 and 64 bit SPE emulation |
|
Date: |
Wed, 04 Jun 2014 14:57:12 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 06/04/2014 02:51 PM, Alexander Graf wrote:
>
> On 04.06.14 23:38, Richard Henderson wrote:
>> On 06/04/2014 02:09 PM, Alexander Graf wrote:
>>> @@ -9030,13 +8820,10 @@ static inline void gen_evmwumi(DisasContext *ctx)
>>> t1 = tcg_temp_new_i64();
>>> /* t0 := rA; t1 := rB */
>>> -#if defined(TARGET_PPC64)
>>> - tcg_gen_ext32u_tl(t0, cpu_gpr[rA(ctx->opcode)]);
>>> - tcg_gen_ext32u_tl(t1, cpu_gpr[rB(ctx->opcode)]);
>>> -#else
>>> tcg_gen_extu_tl_i64(t0, cpu_gpr[rA(ctx->opcode)]);
>>> + tcg_gen_ext32u_i64(t0, t0);
>> Better in one step:
>>
>> tcg_gen_ext32u_i64(t0, cpu_gpr[rA(ctx->opcode)]);
>
> But cpu_gpr can be i32 for qemu-system-ppc, no?
Err.. right. We don't have an extend define for this mix.
r~