[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] active block commit bug?
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] active block commit bug? |
Date: |
Thu, 05 Jun 2014 09:06:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 06/04/2014 08:09 PM, Fam Zheng wrote:
>
>>> Sounds like we have an off-by-one condition if empty files behave
>>> differently from other files. We ought to fix that bug (not that your
>>> normal guest will ever have a 0-length backing file, but this was what I
>>> was trying to use for libvirt's probing of whether active commit is
>>> supported)
>>>
>>
>> Yes, agreed, this special case is only going to make management confused. I
>> will send a patch to fix this.
>
> Thanks.
>
>>
>> Eric, is this a good way to probe the active commit? I was expecting full
>> instrospection of QMP could do it, but I don't know about the status of that
>> piece of work. Amos, any ideas?
>
> Introspection already missed qemu 2.0 when active commit was added; and
> we're close enough to soft freeze for 2.1 that I'm guessing it will miss
> 2.1 as well :(
Almost certainly. It has non-trivial design issues. To have a chance
to make it into 2.x, it needs to be posted for review early in the 2.x
cycle.
[...]
- [Qemu-devel] active block commit bug?, Eric Blake, 2014/06/04
- Re: [Qemu-devel] active block commit bug?, Jeff Cody, 2014/06/04
- Re: [Qemu-devel] active block commit bug?, Eric Blake, 2014/06/04
- Re: [Qemu-devel] active block commit bug?, Fam Zheng, 2014/06/04
- Re: [Qemu-devel] active block commit bug?, Eric Blake, 2014/06/04
- Re: [Qemu-devel] active block commit bug?, Fam Zheng, 2014/06/04
- Re: [Qemu-devel] active block commit bug?,
Markus Armbruster <=
- Re: [Qemu-devel] active block commit bug?, Kevin Wolf, 2014/06/05
- Re: [Qemu-devel] active block commit bug?, Markus Armbruster, 2014/06/05
- Re: [Qemu-devel] active block commit bug?, Amos Kong, 2014/06/06