Re: [Qemu-devel] [PATCH v3 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq

[Stefan Hajnoczi]

On Fri, Jun 06, 2014 at 09:53:21AM +0800, Fam Zheng wrote:
> This unifies the request structure used by dataplane and non-dataplane code,
> while dropping unnessary fields for bounce buffer and read flag.
> 
> Applies on top of Stefan's block tree.
> 
> v3: Address Paolo's comments:
> 
> [06/09] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
>         Add assertion and comments on inhdr.
>         Fix the offset and iov_discard_back.
> 
> [08/09] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
>         Allocate req in process_request.
> 
> [09/09] virtio-blk: Fix and clean up the in_sg and out_sg check
>         New.
> 
> 
> 
> Fam Zheng (9):
>   virtio-blk: Move VirtIOBlockReq to header
>   virtio-blk: Convert VirtIOBlockReq.elem to pointer
>   virtio-blk: Drop bounce buffer from dataplane code
>   virtio-blk: Drop VirtIOBlockRequest.read
>   virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq
>   virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr
>   virtio-blk: Convert VirtIOBlockReq.out to structrue
>   virtio-blk: Fill in VirtIOBlockReq.out in dataplane code
>   virtio-blk: Fix and clean up the in_sg and out_sg check
> 
>  hw/block/dataplane/virtio-blk.c | 167 
> +++++++++++++---------------------------
>  hw/block/virtio-blk.c           | 113 ++++++++++++++-------------
>  include/hw/virtio/virtio-blk.h  |  11 +++
>  3 files changed, 124 insertions(+), 167 deletions(-)

Looks pretty good, just left a few minor comments.