[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be se
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set |
Date: |
Sun, 8 Jun 2014 13:48:25 +0300 |
On Fri, Jun 06, 2014 at 10:26:15PM -0300, Eduardo Habkost wrote:
> It would be much better if we didn't terminate QEMU inside
> device_post_init(), but at least exiting cleanly is better than aborting
> and dumping core.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
> hw/core/qdev.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index e65a5aa..74862c2 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -901,7 +901,13 @@ static void device_initfn(Object *obj)
>
> static void device_post_init(Object *obj)
> {
> - qdev_prop_set_globals(DEVICE(obj), &error_abort);
> + Error *err = NULL;
> + qdev_prop_set_globals(DEVICE(obj), &err);
> + if (err) {
> + qerror_report_err(err);
> + error_free(err);
> + exit(EXIT_FAILURE);
> + }
> }
>
> /* Unlink device from bus and free the structure. */
> --
> 1.9.0
- [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Eduardo Habkost, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Don Slutz, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Igor Mammedov, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Eduardo Habkost, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Igor Mammedov, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Peter Maydell, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Eduardo Habkost, 2014/06/06
- [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set, Eduardo Habkost, 2014/06/06
- Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set,
Michael S. Tsirkin <=
- Re: [Qemu-devel] [PATCH] qdev: Don't abort() in case globals can't be set, Igor Mammedov, 2014/06/09
- Re: [Qemu-devel] [PATCH] qdev: Skip non-existing properties when setting globals, Peter Maydell, 2014/06/07