Re: [Qemu-devel] [PATCH v4 28/29] qmp: add query-memdev

[Hu Tao]

On Mon, Jun 09, 2014 at 11:24:51AM -0600, Eric Blake wrote:
> On 06/09/2014 04:25 AM, Hu Tao wrote:
> > Add qmp command query-memdev to query for information
> > of memory devices
> > 
> > Signed-off-by: Hu Tao <address@hidden>
> > ---
> >  numa.c           | 72 
> > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  qapi-schema.json | 34 ++++++++++++++++++++++++++
> >  qmp-commands.hx  | 32 +++++++++++++++++++++++++
> >  3 files changed, 138 insertions(+)
> > 
> 
> > +
> > +##
> > +# @Memdev:
> > +#
> > +# Information of memory device
> > +#
> > +# @size: memory device size
> > +#
> > +# @host-nodes: host nodes for its memory policy
> > +#
> > +# @policy: memory policy of memory device
> > +#
> 
> You documented three parameters...
> 
> > +# Since: 2.1
> > +##
> > +
> > +{ 'type': 'Memdev',
> > +  'data': {
> > +    'size':       'size',
> > +    'merge':      'bool',
> > +    'dump':       'bool',
> > +    'prealloc':   'bool',
> > +    'host-nodes': ['uint16'],
> > +    'policy':     'HostMemPolicy' }}
> 
> ...but implemented six, all listed as mandatory,...
> 
> > +Show memory devices information.
> > +
> > +
> > +Example (1):
> > +
> > +-> { "execute": "query-memdev" }
> > +<- { "return": [
> > +       {
> > +         "size": 536870912,
> > +         "host-nodes": [0, 1],
> > +         "policy": "bind"
> > +       },
> 
> ...and then only demonstrate 3 in the example.  Something's not quite right.

Thanks for catching this!

Hu