qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 13/17] target-arm: Use uint16_t in syndrome g

From: Greg Bellows
Subject: Re: [Qemu-devel] [PATCH v2 13/17] target-arm: Use uint16_t in syndrome generators with 16bit imms
Date: Wed, 11 Jun 2014 16:19:03 -0500
"not convinced" ... I was just saying that I could not find any benefit for it.  


On 11 June 2014 16:05, Peter Maydell <address@hidden> wrote:
On 11 June 2014 20:19, Greg Bellows <address@hidden> wrote:
> Called out possibly missing fix below.  Beside it, I'm convinced this change
> is beneficial, other than maybe for readability.

"not convinced" ?

Personally, I don't much care either way, but I would suggest that
if you're trying to get a big fat patchset through it's usually better
not to throw in too many not-actually-needed patches :-)

-- PMM

reply via email to
[Prev in Thread] Current Thread [Next in Thread]