[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 6/7] set the frequency of the dump bitmap process
From: |
Sanidhya Kashyap |
Subject: |
[Qemu-devel] [PATCH v3 6/7] set the frequency of the dump bitmap process |
Date: |
Thu, 12 Jun 2014 16:06:39 +0530 |
No, particular change except the function name changed - value_in_range().
Signed-off-by: Sanidhya Kashyap <address@hidden>
---
hmp-commands.hx | 15 +++++++++++++++
hmp.c | 12 ++++++++++++
hmp.h | 1 +
qapi-schema.json | 11 +++++++++++
qmp-commands.hx | 24 ++++++++++++++++++++++++
savevm.c | 14 ++++++++++++++
6 files changed, 77 insertions(+)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index a5174ea..e6138fa 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1818,6 +1818,21 @@ STEXI
Cancel the current bitmap dump process
ETEXI
+ {
+ .name = "ldbsf|log-dirty-bitmap-set-frequency",
+ .args_type = "frequency:i",
+ .params = "frequency",
+ .help = "set the frequency for bitmap dump process\n\t\t\t"
+ "frequency: the new frequency value to replace the
existing",
+ .mhandler.cmd = hmp_log_dirty_bitmap_set_frequency,
+ },
+
+STEXI
address@hidden ldbsf or log-dirty-bitmap-set-frequency @var{frequency}
address@hidden log-dirty-bitmap-set-frequency
+Set the frequency to @var{frequency} (int) for bitmap dump process.
+ETEXI
+
STEXI
@end table
ETEXI
diff --git a/hmp.c b/hmp.c
index fed8795..4dd471d 100644
--- a/hmp.c
+++ b/hmp.c
@@ -1335,6 +1335,18 @@ void hmp_log_dirty_bitmap_cancel(Monitor *mon, const
QDict *qdict)
qmp_log_dirty_bitmap_cancel(NULL);
}
+void hmp_log_dirty_bitmap_set_frequency(Monitor *mon, const QDict *qdict)
+{
+ int64_t frequency = qdict_get_int(qdict, "frequency");
+ Error *err = NULL;
+ qmp_log_dirty_bitmap_set_frequency(frequency, &err);
+ if (err) {
+ monitor_printf(mon, "log-dirty-bitmap-set-frequency: %s\n",
+ error_get_pretty(err));
+ error_free(err);
+ }
+}
+
void hmp_dump_guest_memory(Monitor *mon, const QDict *qdict)
{
Error *err = NULL;
diff --git a/hmp.h b/hmp.h
index 6d4d672..2153e78 100644
--- a/hmp.h
+++ b/hmp.h
@@ -95,6 +95,7 @@ void hmp_object_add(Monitor *mon, const QDict *qdict);
void hmp_object_del(Monitor *mon, const QDict *qdict);
void hmp_log_dirty_bitmap(Monitor *mon, const QDict *qdict);
void hmp_log_dirty_bitmap_cancel(Monitor *mon, const QDict *qdict);
+void hmp_log_dirty_bitmap_set_frequency(Monitor *mon, const QDict *qdict);
void object_add_completion(ReadLineState *rs, int nb_args, const char *str);
void object_del_completion(ReadLineState *rs, int nb_args, const char *str);
void device_add_completion(ReadLineState *rs, int nb_args, const char *str);
diff --git a/qapi-schema.json b/qapi-schema.json
index 9e07f9d..45d7c90 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -3108,3 +3108,14 @@
# Since 2.1
##
{ 'command': 'log-dirty-bitmap-cancel' }
+
+## @log-dirty-bitmap-set-frequency
+#
+# sets the frequency of the dirty bitmap logging process
+# @frequency: the updated frequency value
+#
+# Since 2.1
+##
+{ 'command': 'log-dirty-bitmap-set-frequency',
+ 'data': {'frequency': 'int' } }
+
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 2a8dacc..f27497a 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -3625,3 +3625,27 @@ Example:
<- { "return": {} }
EQMP
+
+ {
+ .name = "log-dirty-bitmap-set-frequency",
+ .args_type = "frequency:i",
+ .mhandler.cmd_new = qmp_marshal_input_log_dirty_bitmap_set_frequency,
+ },
+
+SQMP
+log-dirty-bitmap-set-frequency
+--------------------
+
+Update the frequency for the remaining epochs.
+
+Arguments:
+
+- "frequency": the updated frequency (json-int)
+
+Example:
+
+-> { "execute": "log-dirty-bitmap-set-frequency", "arguments": { "value": 1024
} }
+<- { "return": {} }
+
+EQMP
+
diff --git a/savevm.c b/savevm.c
index e38eca8..4919cc0 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1345,6 +1345,20 @@ void qmp_log_dirty_bitmap_cancel(Error **errp)
logging_bitmap_cancel(logging_current_state());
}
+void qmp_log_dirty_bitmap_set_frequency(int64_t frequency, Error **errp)
+{
+ BitmapLogState *b = logging_current_state();
+ Error *local_err = NULL;
+ if (value_in_range(frequency, MIN_FREQUENCY_VALUE,
+ MAX_FREQUENCY_VALUE, "frequency", &local_err)) {
+ if (local_err) {
+ error_propagate(errp, local_err);
+ return;
+ }
+ }
+ b->current_frequency = frequency;
+}
+
void qmp_xen_save_devices_state(const char *filename, Error **errp)
{
QEMUFile *f;
--
1.9.3
- [Qemu-devel] [PATCH v3 0/7] Obtain dirty bitmap via VM logging, Sanidhya Kashyap, 2014/06/12
- [Qemu-devel] [PATCH v3 1/7] enable sharing of the function between migration and bitmap dump, Sanidhya Kashyap, 2014/06/12
- [Qemu-devel] [PATCH v3 2/7] RunState: added two new flags for bitmap dump and migration process, Sanidhya Kashyap, 2014/06/12
- [Qemu-devel] [PATCH v3 3/7] bitmap dump code via QAPI framework with runstates, Sanidhya Kashyap, 2014/06/12
- [Qemu-devel] [PATCH v3 4/7] hmp interface for dirty bitmap dump, Sanidhya Kashyap, 2014/06/12
- [Qemu-devel] [PATCH v3 5/7] cancel mechanism for an already running dump bitmap process, Sanidhya Kashyap, 2014/06/12
- [Qemu-devel] [PATCH v3 7/7] python script for extracting bitmap from a binary file, Sanidhya Kashyap, 2014/06/12
- [Qemu-devel] [PATCH v3 6/7] set the frequency of the dump bitmap process,
Sanidhya Kashyap <=
- [Qemu-devel] [PATCH v3 3/7][RESEND PATCH] bitmap dump code via QAPI framework with runstates, Sanidhya Kashyap, 2014/06/12