[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH]Fix two functions of the same name
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH]Fix two functions of the same name |
Date: |
Fri, 13 Jun 2014 19:05:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 13.06.2014 13:49, schrieb Lb peace:
> It is funny that we have two sigbus_handler in our QEMU.(exec.c &
> cpus.c)Change one's name.
>
> Signed-off-by: Peace <address@hidden)>
> ---
> cpus.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Technically it does not matter whether two functions have the same name
as long as both are in different compilation units (*.c files) and have
only a local scope (that's what the 'static' keyword does).
There are even function names in QEMU code which occur three or more
times. Look for register_types, for example.
They do you think this should be changed? The only reason I see is that
setting breakpoints while debugging is a little bit more difficult.
Regards
Stefan