Re: [Qemu-devel] [PATCH v5 01/10] block: Auto-generate node_names for each BDS entry

[Eric Blake]

On 06/16/2014 08:10 AM, Benoît Canet wrote:

>> The prefix is to aid in identifying it as a qemu-generated name, the
>> numeric portion is to guarantee uniqueness in a given qemu session, and
>> the random characters are to further avoid any accidental collisions
>> with user-specified node-names.
> 
> if the __qemu## determined a different name space no collision resolution 
> would be
> needed.
> 
> Also Eric you must take care that these node name does not ends up in libvirt
> XML since a new qemu process can generate a new different set of node name.

Correct. Either libvirt will always generate its own node names (and the
presence of a qemu-generated name is a bug in libvirt), or libvirt will
query node-names as it runs, and clear them out when the qemu process
goes away.  It will NOT expose qemu names to user-visible XML (although
it should be safe to save the qemu names to internal-only XML used to
cache results across libvirtd restarts while still communicating to the
same qemu process).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature