[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/27] vmstate: Return error in case of error
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 02/27] vmstate: Return error in case of error |
Date: |
Tue, 17 Jun 2014 11:43:05 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Juan Quintela (address@hidden) wrote:
> If there is an error while loading a field, we should stop reading and
> not continue with the rest of fields. And we should also set an error
> in qemu_file.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> vmstate.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/vmstate.c b/vmstate.c
> index b5882fa..c996520 100644
> --- a/vmstate.c
> +++ b/vmstate.c
> @@ -98,7 +98,11 @@ int vmstate_load_state(QEMUFile *f, const
> VMStateDescription *vmsd,
> ret = field->info->get(f, addr, size);
>
> }
> + if (ret >= 0) {
> + ret = qemu_file_get_error(f);
> + }
> if (ret < 0) {
> + qemu_file_set_error(f, ret);
> trace_vmstate_load_field_error(field->name, ret);
> return ret;
> }
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
I wonder about turning that trace into an error_report; the process is doomed
anyway at this point and it would be nice to know why.
Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
[Qemu-devel] [PATCH 06/27] vmstate: Remove VMSTATE_UINTL_EQUAL_V, Juan Quintela, 2014/06/16