[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qe
|
From: |
Ed Maste |
|
Subject: |
Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu |
|
Date: |
Tue, 17 Jun 2014 15:11:45 -0400 |
On 17 June 2014 13:15, Paolo Bonzini <address@hidden> wrote:
> Il 17/06/2014 19:10, Ed Maste ha scritto:
>
>> This change breaks the build on FreeBSD:
>>
>> libcacard/vscclient.c: In function 'send_msg':
>> libcacard/vscclient.c:111: warning: implicit declaration of function
>> 'htonl'
>> ...
>
> Can you prepare a patch yourself? I would be guessing the right header to
> include, sorry.
I can get it to build by either restoring the #include of
qemu/sockets.h, or explicitly #including sys/socket.h and
netinet/in.h. I'm happy to send a signed-off patch for either change,
but it seems there must be more to the original change that I'm
missing. What provides the declarations for socket(), htonl(),
AF_INET etc. in the Linux build?
[Qemu-devel] [PULL 3/8] libcacard: replace qemu thread primitives with glib ones, Paolo Bonzini, 2014/06/10
[Qemu-devel] [PULL 6/8] rules.mak: Rewrite unnest-vars, Paolo Bonzini, 2014/06/10
[Qemu-devel] [PULL 8/8] configure: unset interfering variables, Paolo Bonzini, 2014/06/10
[Qemu-devel] [PULL 7/8] configure: duplicate/incorrect order of -lrt, Paolo Bonzini, 2014/06/10
Re: [Qemu-devel] [PULL 0/8] build system and libcacard changes for 2014-06-10, Peter Maydell, 2014/06/10