qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 2/4] qtest: introduce qmp_exec_hmp_cmd()


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v4 2/4] qtest: introduce qmp_exec_hmp_cmd()
Date: Wed, 18 Jun 2014 09:05:06 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 18/06/2014 08:29, Amos Kong ha scritto:
> Instead of adding g_strescape everywhere, we should use json-parser's own
> interpolation support.  See this patch:
> http://article.gmane.org/gmane.comp.emulators.qemu/279836 which also fixes a
> leak as a bonus.
>
> Also, you can use ' instead of " if you fix another long-standing bug:
> http://article.gmane.org/gmane.comp.emulators.qemu/279835
I will use ' instead of ", and escape string in QMP command as 
http://article.gmane.org/gmane.comp.emulators.qemu/279836

Thanks Amos! This will avoid duplicating work as well as semantic conflicts. I've added your Reviewed-by for the lexer patch.

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]