[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB e
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB events |
Date: |
Wed, 18 Jun 2014 22:11:31 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/18/2014 12:43 AM, Paolo Bonzini wrote:
> From: Wenchao Xia <address@hidden>
>
> Since BLOCK_JOB_COMPLETED, BLOCK_JOB_CANCELLED, BLOCK_JOB_READY are
> related, convert them in one patch. The block_job_event_* functions
> are used to keep encapsulation of BlockJob structure.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> +++ b/include/block/blockjob.h
> @@ -217,12 +217,21 @@ void block_job_pause(BlockJob *job);
> void block_job_resume(BlockJob *job);
>
> /**
> - * qobject_from_block_job:
> + * block_job_event_cancle:
s/cancle/cancel/
At this point, if you need to clean it up in a followup patch instead of
delaying the series, I can live with it.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 2.1 16/36] qapi event: convert WAKEUP, (continued)
- [Qemu-devel] [PATCH 2.1 16/36] qapi event: convert WAKEUP, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 13/36] qapi event: convert RESUME, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 17/36] qapi event: convert RTC_CHANGE, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 18/36] qapi event: convert WATCHDOG, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 19/36] qapi event: convert DEVICE_DELETED, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 20/36] qapi event: convert DEVICE_TRAY_MOVED, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 22/36] qapi event: convert BLOCK_IMAGE_CORRUPTED, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 23/36] qapi event: convert other BLOCK_JOB events, Paolo Bonzini, 2014/06/18
- [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Paolo Bonzini, 2014/06/18
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Markus Armbruster, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Paolo Bonzini, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Luiz Capitulino, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Markus Armbruster, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Luiz Capitulino, 2014/06/26
- Re: [Qemu-devel] [PATCH 2.1 21/36] qapi event: convert BLOCK_IO_ERROR and BLOCK_JOB_ERROR, Markus Armbruster, 2014/06/27