qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 2.1 31/36] qemu-char: introduce qemu_chr_alloc
Date: Thu, 19 Jun 2014 14:52:32 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 19/06/2014 14:03, Eric Blake ha scritto:
On 06/18/2014 12:43 AM, Paolo Bonzini wrote:
The next patch will modify this function to initialize state that is
common to all backends.

Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
 backends/baum.c       |  2 +-
 backends/msmouse.c    |  2 +-
 include/sysemu/char.h |  9 +++++++++
 qemu-char.c           | 32 +++++++++++++++++++-------------
 spice-qemu-char.c     |  2 +-
 ui/console.c          |  2 +-
 6 files changed, 32 insertions(+), 17 deletions(-)

Missing hw/misc/ivshmem.c:

static int pci_ivshmem_init(PCIDevice *dev)
{
...
        s->eventfd_chr = g_malloc0(s->vectors * sizeof(CharDriverState *));

        qemu_chr_add_handlers(s->server_chr, ivshmem_can_receive,
ivshmem_read,
                     ivshmem_event, s);


Is that going to matter?  If not,

Heh, I did the same wrong grep when writing the patch. :)

This is allocating a vector of _pointers_ to CharDriverState. The pointers are initialized separately using create_eventfd_chr_device (that uses qemu_chr_open_eventfd and hence qemu_chr_alloc).

Paolo

Reviewed-by: Eric Blake <address@hidden>





reply via email to

[Prev in Thread] Current Thread [Next in Thread]