|
From: | Max Reitz |
Subject: | Re: [Qemu-devel] [PATCH v2 1/3] nbd: Drop nbd_can_read() |
Date: | Fri, 20 Jun 2014 19:04:19 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 19.06.2014 10:44, Paolo Bonzini wrote:
Il 18/06/2014 21:06, Max Reitz ha scritto:+static void nbd_set_handlers(NBDClient *client) +{ + if (client->exp && client->exp->ctx) { + aio_set_fd_handler(client->exp->ctx, client->sock, + client->can_read ? nbd_read : NULL,+ client->send_coroutine ? nbd_restart_write : NULL,+ client); + } +}Note that aio_set_fd_handler doesn't exist on Windows (yet), so this patch breaks compilation on Windows. We can fix this for 2.2 and then apply your patches.
Okay, I'll add "for 2.2" to the subject and a comment to the cover letter for v3.
Max
[Prev in Thread] | Current Thread | [Next in Thread] |