[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] coroutine-win32.c: Add noinline attribute to wo
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] coroutine-win32.c: Add noinline attribute to work around gcc bug |
|
Date: |
Mon, 23 Jun 2014 08:55:58 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/23/2014 08:02 AM, Paolo Bonzini wrote:
> * I would apply the workaround on all backends, just to be safe. I guess the
> block maintainers can do that.
The other backends don't use TLS, they use pthread_getspecific, which is a
normal function call that gcc will not hoist out of the loop. Therefore the
other backends do not suffer from the same problem.
It's also
Reviewed-by: Richard Henderson <address@hidden>
r~