[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to n
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers |
Date: |
Wed, 25 Jun 2014 09:53:53 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/25/2014 08:35 AM, Kevin Wolf wrote:
> Since we parse backing.* options to add a backing file from the command
> line when the driver didn't assign one, it has been possible to have a
> backing file for e.g. raw images (it just was never accessed).
>
> This is obvious nonsense and should be rejected.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 7 +++++++
> block/cow.c | 1 +
> block/qcow.c | 1 +
> block/qcow2.c | 1 +
> block/qed.c | 1 +
> block/vmdk.c | 1 +
> include/block/block_int.h | 3 +++
> tests/qemu-iotests/051 | 5 +++++
> tests/qemu-iotests/051.out | 9 +++++++++
> 9 files changed, 29 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 1/9] block: Create bdrv_fill_options(), (continued)
- [Qemu-devel] [PATCH v2 1/9] block: Create bdrv_fill_options(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 5/9] block: Use common driver selection code for bdrv_open_file(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 3/9] block: Move json: parsing to bdrv_fill_options(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 4/9] block: Always pass driver name through options QDict, Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 6/9] block: Inline bdrv_file_open(), Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 7/9] block: Remove second bdrv_open() recursion, Kevin Wolf, 2014/06/25
- [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers, Kevin Wolf, 2014/06/25
- Re: [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers,
Eric Blake <=
- [Qemu-devel] [PATCH v2 9/9] block: Remove a special case for protocols, Kevin Wolf, 2014/06/25
- Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1, Kevin Wolf, 2014/06/26
- Re: [Qemu-devel] [PATCH v2 0/9] bdrv_open() cleanups, part 1, Max Reitz, 2014/06/26