qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to n


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 8/9] block: Catch backing files assigned to non-COW drivers
Date: Wed, 25 Jun 2014 09:53:53 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 06/25/2014 08:35 AM, Kevin Wolf wrote:
> Since we parse backing.* options to add a backing file from the command
> line when the driver didn't assign one, it has been possible to have a
> backing file for e.g. raw images (it just was never accessed).
> 
> This is obvious nonsense and should be rejected.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  block.c                    | 7 +++++++
>  block/cow.c                | 1 +
>  block/qcow.c               | 1 +
>  block/qcow2.c              | 1 +
>  block/qed.c                | 1 +
>  block/vmdk.c               | 1 +
>  include/block/block_int.h  | 3 +++
>  tests/qemu-iotests/051     | 5 +++++
>  tests/qemu-iotests/051.out | 9 +++++++++
>  9 files changed, 29 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]