[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind |
|
Date: |
Mon, 30 Jun 2014 11:33:08 +0100 |
On 30 June 2014 11:23, Gerd Hoffmann <address@hidden> wrote:
> Hi,
>
>> > * The old qemu_chr_open_socket() has an
>> > "if (!is_waitconnect)
>> > qemu_set_nonblock(fd);
>> > which the QMP char-open codepath has never had. Does this matter?
>> > Which of the two code paths was correct?
>>
>> Gerd?
>
> IIRC the socket is put into non-blocking mode anyway by the qemu socket
> helper functions.
In that case is qemu_chr_open_socket_fd() incorrect
in marking the socket as nonblocking in the
is_listen && is_waitconnect case?
-- PMM
- [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Peter Maydell, 2014/06/20
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Markus Armbruster, 2014/06/23
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Peter Maydell, 2014/06/23
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Gerd Hoffmann, 2014/06/30
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Gerd Hoffmann, 2014/06/30
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Peter Maydell, 2014/06/30
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Paolo Bonzini, 2014/06/30
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Peter Maydell, 2014/06/30
- Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind, Paolo Bonzini, 2014/06/30