qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRD


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH] ahci.c: mask unused flags when reading size PRDT DBC
Date: Mon, 30 Jun 2014 14:09:39 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0


On 29.06.14 20:21, address@hidden wrote:
This requires a custom ovmf image with sata controller for testing [0]

[0]: http://reza.jelveh.me/assets/OVMF.fd.bz2


I guess this is supposed to be a cover letter? A few rules for cover letters:

1) Cover letters only make sense for patch sets. This is a single patch, so you don't need one 2) Because they come with patch sets and you number patch sets, cover letters are [PATCH 0/n]. 3) Usually cover letters contain git statistics. Try git format-patch --cover-letter. It will give you a nice template.

The usual way to add the comment you have here to a patch you're trying to submit it is to put volatile information (things that shouldn't end up in the git log) behind a "---" line in the commit message. Everything after that line gets ignored by git when the patch gets applied.


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]