qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for 2.1] qapi: Change back sector-count to secto


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for 2.1] qapi: Change back sector-count to sectors-count in quorum QAPI events.
Date: Mon, 30 Jun 2014 09:58:05 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0

On 06/30/2014 09:05 AM, Benoît Canet wrote:
> fe069d9d had aligned code and documentation while dropping the s from the
> actual JSON output. Fix that.

Uggh. I missed that in my review (I was obviously less careful in the
second half of the series than in the first half).  It's annoying that
we have an inconsistency, but back-compat demands that we preserve the
spelling difference between the parameters.  This needs to go in to
avoid a regression.

> 
> This also fix test/qemu-iotest/081 since the missing s was causing a 
> permutation.
> 
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  docs/qmp/qmp-events.txt | 26 +++++++++++++-------------
>  qapi/event.json         |  8 ++++----
>  2 files changed, 17 insertions(+), 17 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]