Re: Ping: [PATCH] Emulate dip switch language layout settings on SUN keyboard

[Artyom Tarasenko]

On Mon, Aug 3, 2020 at 8:36 PM Henrik Carlqvist <hc981@poolhem.se> wrote:
>
> Thanks for finding my typos!

:-)

> On Mon, 3 Aug 2020 20:16:43 +0200
> Artyom Tarasenko <atar4qemu@gmail.com> wrote:
>
> > > > On Fri, 10 Jul 2020 20:19:11 +0200
> > > > Henrik Carlqvist <hc981@poolhem.se> wrote:
> > > >> hardcoded to allways use an US keyboard layout.
>
> > Can you please move this description to the commit message? (Fixing
> > typo in "always" ;-) )
>
> I don't think I have access to push commits to the git repo, or did you mean
> that Paolo should make the commit?

I mean the part of the commit message before "From 2f86bd..." will be
lost after committing, and I would like to preserve the link to the
documentation and the invocation command.

>
> > >> Subject: [PATCH] Emulating sun keyboard languate layout dip switches,
>
> > typo: language
>
> > Looks good otherwise. For the v2:
> > Reviewed-by: Artyom Tarasenko <atar4qemu@gmail.com>
>
> Do you want me to post the same patch again to the mailing list with corrected
> typos in subject and description?
>

Yes, please.



-- 
Regards,
Artyom Tarasenko

SPARC and PPC PReP under qemu blog: http://tyom.blogspot.com/search/label/qemu