qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/7] minikconf: Pass variables for modules


From: Gerd Hoffmann
Subject: Re: [PATCH 3/7] minikconf: Pass variables for modules
Date: Tue, 4 Aug 2020 08:19:16 +0200

On Thu, Jul 23, 2020 at 07:46:11PM +0200, Christophe de Dinechin wrote:
> Signed-off-by: Christophe de Dinechin <dinechin@redhat.com>
> ---
>  scripts/minikconf.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/minikconf.py b/scripts/minikconf.py
> index bcd91015d3..d60add97f6 100755
> --- a/scripts/minikconf.py
> +++ b/scripts/minikconf.py
> @@ -690,10 +690,10 @@ if __name__ == '__main__':
>      parser = KconfigParser(data)
>      external_vars = set()
>      for arg in argv[3:]:
> -        m = re.match(r'^(CONFIG_[A-Z0-9_]+)=([yn]?)$', arg)
> +        m = re.match(r'^(CONFIG_[A-Z0-9_]+)=([ymn]?)$', arg)
>          if m is not None:
>              name, value = m.groups()
> -            parser.do_assignment(name, value == 'y')
> +            parser.do_assignment(name, value == 'y' or value == 'm')
>              external_vars.add(name[7:])
>          else:
>              fp = open(arg, 'rt', encoding='utf-8')

Hmm, I somehow doubt it is _that_ simple, miniconf supports only bool
(y+n) not tristate (y+n+m) ...

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]