Re: [PATCH for-5.1] Add GitHub action for Windows build

[Daniel P . Berrangé]

On Tue, Aug 04, 2020 at 09:29:50AM +0200, Philippe Mathieu-Daudé wrote:

> > diff --git a/.github/workflows/win.yml b/.github/workflows/win.yml
> > new file mode 100644
> > index 0000000000..81cf48530f
> > --- /dev/null
> > +++ b/.github/workflows/win.yml
> > @@ -0,0 +1,34 @@
> > +# GitHub actions - Create QEMU installers for Windows
> > +
> > +# The action is restricted to https://github.com/qemu/qemu.
> > +# That avoids an unnecessary waste of resources when each fork
> > +# runs the action, too.
> > +
> > +name: Cross build for Windows
> > +
> > +on: [push]
> > +
> > +jobs:
> > +  build32:
> > +    if: github.repository == 'qemu/qemu'
> > +    runs-on: [ubuntu-20.04]
> 
> Since it is based on Ubuntu, we should be able to run it on GitLab
> directly (and simplifies our CI). Also we could drop the Shippable
> docker images too.
> 
> This works, so:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> But I'm not keen on not using GitLab instead.

Agreed, I realllly don't want to see us introduce yet another CI
environment. This increases the cost for maintainers and contributors
alike. Especially as we're introducing GitLab as our gating CI
platform, we need to be doing whatever we can to consolidate stuff
onto GitLab CI, not adding new CI systems.

For things we can't do in GitLab CI directly, we need to use a
shim job in GitLab that calls out to the alternative service
and sends results back, so that we still have GitLab as the
single portal to watch all jobs. eg  cirrus-run for integrating
with Cirrus CI.

> The only point I see of using GitHub/Azureus is if we then install
> and run testing in the Windows Server 2019 environment:
> 
> https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idruns-on

Cirrus CI has the ability to provide Windows Service 2019 containers
too, and since we already use Cirrus CI and can integrate it with
GitLab via cirrrus-run, I think that's preferrable to GitHub.

https://cirrus-ci.org/guide/windows/

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|