[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-vis
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH] Fixes: Fallthrough warning on line 270 of qemu/qapi/opts-visitor.c |
Date: |
Sat, 15 Aug 2020 17:28:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
This is v3 with no change w.r.t. v1/v2 (except this time you correctly
Cc'ed the maintainers). Maybe something is wrong in your setup?
On 8/15/20 5:12 PM, Rohit Shinde wrote:
> Added the fallthrough comment so that the compiler doesn't emit an error on
> compiling with the -Wimplicit-fallthrough flag.
>
> Signed-off-by: Rohit Shinde <rohit.shinde12194@gmail.com>
> ---
> qapi/opts-visitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
> index 7781c23a42..43cf60d3a0 100644
> --- a/qapi/opts-visitor.c
> +++ b/qapi/opts-visitor.c
> @@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t size)
> }
> ov->list_mode = LM_IN_PROGRESS;
> /* range has been completed, fall through in order to pop option */
> + __attribute__((fallthrough));
>
> case LM_IN_PROGRESS: {
> const QemuOpt *opt;
>