Re: [PATCH v4 0/9] memory: assert and define MemoryRegionOps callbacks

[Philippe Mathieu-Daudé]

On 8/11/20 1:41 PM, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
> 
> Hello,
> 
> * This series asserts that MemoryRegionOps objects define read/write
>   callback methods. Thus avoids potential NULL pointer dereference.
>   ex. -> 
> https://git.qemu.org/?p=qemu.git;a=commit;h=bb15013ef34617eb1344f5276292cadd326c21b2
> 
> * Also adds various undefined MemoryRegionOps read/write functions
>   to avoid potential assert failure.

What about read_with_attrs()/write_with_attrs()?
It seems they are part of the same problem.

> 
> Thank you.
> --
> Prasad J Pandit (9):
>   hw/pci-host: add pci-intack write method
>   pci-host: designware: add pcie-msi read method
>   vfio: add quirk device write method
>   prep: add ppc-parity write method
>   nvram: add nrf51_soc flash read method
>   spapr_pci: add spapr msi read method
>   tz-ppc: add dummy read/write methods
>   imx7-ccm: add digprog mmio write method
>   memory: assert MemoryRegionOps callbacks are defined
> 
>  hw/misc/imx7_ccm.c       |  8 ++++++++
>  hw/misc/tz-ppc.c         | 14 ++++++++++++++
>  hw/nvram/nrf51_nvm.c     | 10 ++++++++++
>  hw/pci-host/designware.c | 19 +++++++++++++++++++
>  hw/pci-host/prep.c       |  8 ++++++++
>  hw/ppc/prep_systemio.c   |  8 ++++++++
>  hw/ppc/spapr_pci.c       | 14 ++++++++++++--
>  hw/vfio/pci-quirks.c     |  8 ++++++++
>  softmmu/memory.c         | 10 +++++++++-
>  9 files changed, 96 insertions(+), 3 deletions(-)
> 
> --
> 2.26.2
>