Re: [PATCH v3 00/10] *** A Method for evaluating dirty page rate ***

[no-reply]

Patchew URL: 
1597634433-18809-1-git-send-email-zhengchuan@huawei.com/">https://patchew.org/QEMU/1597634433-18809-1-git-send-email-zhengchuan@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1597634433-18809-1-git-send-email-zhengchuan@huawei.com
Subject: [PATCH v3 00/10] *** A Method for evaluating dirty page rate ***

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         
patchew/1597634433-18809-1-git-send-email-zhengchuan@huawei.com -> 
patchew/1597634433-18809-1-git-send-email-zhengchuan@huawei.com
Switched to a new branch 'test'
ce6fe0d migration/dirtyrate: Implement 
qmp_cal_dirty_rate()/qmp_get_dirty_rate() function
96ce007 migration/dirtyrate: Implement calculate_dirtyrate() function
42642d4 migration/dirtyrate: Implement get_sample_page_period() and 
block_sample_page_period()
3a4d4a2 migration/dirtyrate: skip sampling ramblock with size below 
MIN_RAMBLOCK_SIZE
31f35b7 migration/dirtyrate: Compare page hash results for recorded sampled page
a3d582d migration/dirtyrate: Record hash results for each sampled page
85c6447 migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h
c7c94cc migration/dirtyrate: Add dirtyrate statistics series functions
a76c0d0 migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info
7f6092c migration/dirtyrate: Add get_dirtyrate_thread() function

=== OUTPUT BEGIN ===
1/10 Checking commit 7f6092c52d5c (migration/dirtyrate: Add 
get_dirtyrate_thread() function)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 115 lines checked

Patch 1/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/10 Checking commit a76c0d08e93d (migration/dirtyrate: Add RamlockDirtyInfo to 
store sampled page info)
3/10 Checking commit c7c94cc4c17d (migration/dirtyrate: Add dirtyrate 
statistics series functions)
4/10 Checking commit 85c64473ab70 (migration/dirtyrate: move 
RAMBLOCK_FOREACH_MIGRATABLE into ram.h)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#63: FILE: migration/ram.h:42:
+#define RAMBLOCK_FOREACH_NOT_IGNORED(block)            \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (ramblock_is_ignored(block)) {} else

ERROR: trailing statements should be on next line
#65: FILE: migration/ram.h:44:
+        if (ramblock_is_ignored(block)) {} else

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#67: FILE: migration/ram.h:46:
+#define RAMBLOCK_FOREACH_MIGRATABLE(block)             \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (!qemu_ram_is_migratable(block)) {} else

ERROR: trailing statements should be on next line
#69: FILE: migration/ram.h:48:
+        if (!qemu_ram_is_migratable(block)) {} else

ERROR: braces {} are necessary for all arms of this statement
#69: FILE: migration/ram.h:48:
+        if (!qemu_ram_is_migratable(block)) {} else
[...]
+        if (!qemu_ram_is_migratable(block)) {} else
[...]

total: 5 errors, 0 warnings, 45 lines checked

Patch 4/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/10 Checking commit a3d582d88093 (migration/dirtyrate: Record hash results for 
each sampled page)
6/10 Checking commit 31f35b73e761 (migration/dirtyrate: Compare page hash 
results for recorded sampled page)
7/10 Checking commit 3a4d4a207812 (migration/dirtyrate: skip sampling ramblock 
with size below MIN_RAMBLOCK_SIZE)
8/10 Checking commit 42642d45cf29 (migration/dirtyrate: Implement 
get_sample_page_period() and block_sample_page_period())
9/10 Checking commit 96ce00742d23 (migration/dirtyrate: Implement 
calculate_dirtyrate() function)
10/10 Checking commit ce6fe0d124c5 (migration/dirtyrate: Implement 
qmp_cal_dirty_rate()/qmp_get_dirty_rate() function)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1597634433-18809-1-git-send-email-zhengchuan@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/1597634433-18809-1-git-send-email-zhengchuan@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com