Re: [PATCH] hw: dev-wacom: Support wacom tablet emulation in linux qemu

[Michael Nazzareno Trimarchi]

Hi Gerd

On Mon, Aug 17, 2020 at 8:47 AM Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> On Wed, Aug 12, 2020 at 05:21:49PM +0200, Michael Trimarchi wrote:
> > Linux need to fill up the hid descriptor in order to let
> > the driver be emulated. This patch was tested on top of
> > qemu 4.2.0 and recent linux kernel.
> >
> > modprobe wacom.ko
> > evtest tool
> >
> > Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> > ---
> >  hw/usb/dev-wacom.c | 70 ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 70 insertions(+)
> >
> > diff --git a/hw/usb/dev-wacom.c b/hw/usb/dev-wacom.c
> > index 8aba44b8bc..fe95699672 100644
> > --- a/hw/usb/dev-wacom.c
> > +++ b/hw/usb/dev-wacom.c
> > @@ -259,6 +259,64 @@ static void usb_wacom_handle_reset(USBDevice *dev)
> >      s->mode = WACOM_MODE_HID;
> >  }
> >
> > +static const uint8_t qemu_wacom_hid_report_descriptor[] = {
> > +     0x05, 0x01,
> > +     0x09, 0x02,
>
> Where does this come from?  Created from scratch?  Copied from real

No, there are dump of several descriptor on github. I will put in the
commit message

> wacom tablet?  Any chance this can get descriptive comments like the
> other report descriptors (see dev-hid.c)?

Yes, no problem. I will study a bit more. How was working before?

Michael

>
> thanks,
>   Gerd
>


-- 
Michael Nazzareno Trimarchi
Amarula Solutions BV
COO Co-Founder
Cruquiuskade 47 Amsterdam 1018 AM NL
T. +31(0)851119172
M. +39(0)3479132170
[`as] https://www.amarulasolutions.com