qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 000/150] Meson integration for 5.2


From: Paolo Bonzini
Subject: Re: [PATCH v2 000/150] Meson integration for 5.2
Date: Mon, 17 Aug 2020 13:24:50 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 17/08/20 13:02, Roman Bolshakov wrote:
> 
> Tested-by: Roman Bolshakov <r.bolshakov@yadro.com>
> 
> On the next step, it might be good to drop configure in favor of meson
> configuration, so configure, build and test commands would be similar to
> libvirt:
> 
> meson build
> ninja -C build
> meson test -C build

Well, there are quite a few steps needed to get there:

1) moving feature tests from configure to Meson is a no-brainer.
However it's better to first convert the unit tests to Meson and get rid
of the rest of rules.mak.  This is because it's simpler to do this if
there are no uses left of CONFIG_* symbols in the Makefiles.

2) moving the rest of "make install" to Meson is even more of a
no-brainer.  Marc-André has patches there.  They also include a
conversion of the ROM build.

3) moving the bulk of the build from meson to ninja is possible and I
already have patches for it.  It requires adding ninja as a build
dependency however.  The main advantage here is getting rid of
Ninjatool.  I'm not sure how moving the handling of submodules to Meson
would work, and that's needed in order to be able to build with "ninja
-C build".

4) I find "meson test" to be inferior in some respects to the QEMU's TAP
test harness.  In particular, one feature of QEMU's Makefiles is that
you can cut-and-paste from "make V=1 output" into the shell.  So that
part may take some time.  I'd rather extend Meson so that it's possible
to write arbitrary test runners.

Thanks,

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]