[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 27/41] qom: Fix G_DEFINE_AUTOPTR_CLEANUP_FUNC
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 27/41] qom: Fix G_DEFINE_AUTOPTR_CLEANUP_FUNC |
|
Date: |
Mon, 17 Aug 2020 17:04:25 +0100 |
|
User-agent: |
Mutt/1.14.5 (2020-06-23) |
On Thu, Aug 13, 2020 at 06:26:11PM -0400, Eduardo Habkost wrote:
> ModuleObjName##Class was being used instead of ModuleObjName.
> Fix it.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> include/qom/object.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
though I'd suggest just squashing it into the original buggy
patch.
>
> diff --git a/include/qom/object.h b/include/qom/object.h
> index be64421089..f515230f61 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -571,7 +571,7 @@ struct Object
> typedef struct ModuleObjName ModuleObjName; \
> typedef struct ModuleObjName##Class ModuleObjName##Class; \
> \
> - G_DEFINE_AUTOPTR_CLEANUP_FUNC(ModuleObjName##Class, object_unref) \
> + G_DEFINE_AUTOPTR_CLEANUP_FUNC(ModuleObjName, object_unref) \
> \
> static inline G_GNUC_UNUSED ModuleObjName##Class * \
> MODULE_OBJ_NAME##_GET_CLASS(void *obj) \
> --
> 2.26.2
>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 17/41] pci: Move PCIBusClass typedef to pci.h, (continued)
- [PATCH 21/41] s390_flic: Move KVMS390FLICState typedef to header, Eduardo Habkost, 2020/08/13
- [PATCH 22/41] can_emu: Delete macros for non-existing typedef, Eduardo Habkost, 2020/08/13
- [PATCH 24/41] platform-bus: Delete macros for non-existing typedef, Eduardo Habkost, 2020/08/13
- [PATCH 27/41] qom: Fix G_DEFINE_AUTOPTR_CLEANUP_FUNC, Eduardo Habkost, 2020/08/13
- Re: [PATCH 27/41] qom: Fix G_DEFINE_AUTOPTR_CLEANUP_FUNC,
Daniel P . Berrangé <=
- [PATCH 20/41] mcf_fec: Move mcf_fec_state typedef to header, Eduardo Habkost, 2020/08/13
- [PATCH 23/41] nubus: Delete unused NUBUS_BRIDGE macro, Eduardo Habkost, 2020/08/13
- [PATCH 25/41] qom: make object_ref/unref use a void * instead of Object *., Eduardo Habkost, 2020/08/13
- [PATCH 26/41] qom: provide convenient macros for declaring and defining types, Eduardo Habkost, 2020/08/13
- [PATCH 30/41] qom: Make type checker functions accept const pointers, Eduardo Habkost, 2020/08/13