Re: [PATCH 14/17] crypto/builtin: Split and simplify AES_encrypt_cbc

[Daniel P . Berrangé]

On Wed, Aug 12, 2020 at 08:25:34PM -0700, Richard Henderson wrote:
> Split into encrypt/decrypt functions, dropping the "enc" argument.
> Now that the function is private to this file, we know that "len"
> is a multiple of AES_BLOCK_SIZE.  So drop the odd block size code.
> 
> Name the functions do_aes_*crypt_cbc to match the *_ecb functions.
> Reorder and re-type the arguments to match as well.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  crypto/cipher-builtin.inc.c | 91 +++++++++++++++----------------------
>  1 file changed, 36 insertions(+), 55 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|