Re: [PATCH 2/6] vhost-user-server: drop unused #include <eventfd.h>

[Stefan Hajnoczi]

On Mon, Aug 17, 2020 at 08:49:27PM +0800, Coiby Xu wrote:
> On Fri, Jun 19, 2020 at 01:00:42PM +0100, Stefan Hajnoczi wrote:
> > Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> > ---
> > util/vhost-user-server.c | 1 -
> > 1 file changed, 1 deletion(-)
> > 
> > diff --git a/util/vhost-user-server.c b/util/vhost-user-server.c
> > index e94a8d8a83..49ada8bc78 100644
> > --- a/util/vhost-user-server.c
> > +++ b/util/vhost-user-server.c
> > @@ -7,7 +7,6 @@
> >  * later.  See the COPYING file in the top-level directory.
> >  */
> > #include "qemu/osdep.h"
> > -#include <sys/eventfd.h>
> > #include "qemu/main-loop.h"
> > #include "vhost-user-server.h"
> > 
> > --
> > 2.26.2
> > 
> 
> All the patches have been applied to v10. I'm curious how do you find
> this issue. Is there a tool to detect this issue or simply you are so
> familiar with the QEMU code that you can spot it very easily?

No, I didn't use a tool.

When looking at the code I wondered if the #include was really
necessary. So I deleted the #include and recompiled to check that the
build still works.

Stefan

signature.asc
Description: PGP signature