Re: [PATCH] tests: docker: support mxe-based mingw builds

[Paolo Bonzini]

On 19/08/20 13:09, Daniel P. Berrangé wrote:
> On Wed, Aug 19, 2020 at 12:42:44PM +0200, Paolo Bonzini wrote:
>> On 19/08/20 10:20, Daniel P. Berrangé wrote:
>>> We already have docker containers with MXE based on Debian:
>>>
>>>   debian-win32-cross.docker
>>>   debian-win64-cross.docker
>>>
>>> your image uses a different naming convention, and puts both
>>> 32 and 64 bit in the same image.
>>
>> Yeah, that's what test-mingw expects.
> 
> Ah, I missed that.
> 
>>
>>> I feel like we should have the Ubuntu variant follow the same
>>> structure and naming as the Debian variant for consistency.
>>
>> My patch follows the Fedora variant, so that test-mingw runs.  That
>> ensures that NSIS is covered as well.  One possibility could be:
>>
>> - create fedora-win*-cross dockerfiles
> 
> Yeah, I think that'd make sense, as it'd enable a simple trick we
> do in libvirt.
> 
> In all the dockerfile recipe we set an env
> 
>   ENV MESON_OPTS "--cross-file=/usr/share/mingw/toolchain-mingw32.meson"
> 
> And in other linux-cross builds, we do similar
> 
>   ENV MESON_OPTS "--cross-file=i686-linux-gnu"

Yeah, that's the same as QEMU's QEMU_CONFIGURE_OPTS.

>> - add ENV FEATURES $FEATURES mingw to the win*-cross dockerfiles
>>
>> - look for the feature in test-full and test-quick, and run "make
>> installer" if so.
> 
> I'd suggest that "make installer" should be a part of "make" not
> a separate thing that needs running manually.
> 
> eg if we're configure'ing for mingw, configure should check whether
> we have the NSIS tools available and if so, then enable NSIS as a
> standard build output. We could have a configure option to enable/disable
> NSIS explicitly.
> 
> This  eliminates the second bit of special casing for mingw

Yeah, that might be an idea.  I'm not sure if it would work however
because "make installer" invokes "make install", so there could be
recursive (and non-reentrant) invocations.

Paolo