Re: [PATCH v1] pc: fix auto_enable_numa_with_memhp/auto_enable_numa_with_memdev for the 5.0 machine

[Dr. David Alan Gilbert]

* David Hildenbrand (david@redhat.com) wrote:
> Unfortunately, a typo sneeked in: we want to set
> auto_enable_numa_with_memdev to false, not auto_enable_numa_with_memhp.
> 
> Cc: qemu-stable@nongnu.org # v5.1
> Fixes: 195784a0cfad (numa: Auto-enable NUMA when any memory devices are 
> possible)
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  hw/i386/pc_q35.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
> index a3e607a544..e94f45779b 100644
> --- a/hw/i386/pc_q35.c
> +++ b/hw/i386/pc_q35.c
> @@ -371,7 +371,7 @@ static void pc_q35_5_0_machine_options(MachineClass *m)
>      m->numa_mem_supported = true;
>      compat_props_add(m->compat_props, hw_compat_5_0, hw_compat_5_0_len);
>      compat_props_add(m->compat_props, pc_compat_5_0, pc_compat_5_0_len);
> -    m->auto_enable_numa_with_memhp = false;
> +    m->auto_enable_numa_with_memdev = false;
>  }
>  
>  DEFINE_Q35_MACHINE(v5_0, "pc-q35-5.0", NULL,
> -- 
> 2.26.2
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK