qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] qemu-iotests: Fix FilePaths cleanup


From: Eric Blake
Subject: Re: [PATCH] qemu-iotests: Fix FilePaths cleanup
Date: Thu, 20 Aug 2020 16:32:08 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 8/20/20 4:29 PM, Eric Blake wrote:
On 8/20/20 4:19 PM, Nir Soffer wrote:
If os.remove() fails to remove one of the paths, for example if the file
was removed by the test, the cleanup loop would exit silently, without
removing the rest of the files.

Signed-off-by: Nir Soffer <nsoffer@redhat.com>
---
  dtc                           | 2 +-
  tests/qemu-iotests/iotests.py | 8 ++++----
  2 files changed, 5 insertions(+), 5 deletions(-)


Reviewed-by: Eric Blake <eblake@redhat.com>

By the way, what test did you hit this on? If possible, I'd like to add a Fixes: tag pointing to a commit that includes the problem.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




reply via email to

[Prev in Thread] Current Thread [Next in Thread]