qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 1/1] audio/jack: fix use after free segfault


From: Paolo Bonzini
Subject: Re: [PATCH v5 1/1] audio/jack: fix use after free segfault
Date: Fri, 21 Aug 2020 15:13:56 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0

On 21/08/20 13:28, Geoffrey McRae wrote:
> 
>> My suggestion is to work towards protecting the audio code with its own
>> mutex(es) and ignore the existence of the BQL for subsystems that can do
>> so (audio is a prime candidate).  Also please add comments to
>> audio_int.h about which functions are called from other threads than the
>> QEMU main thread.
> 
> Ok, so to get back on topic, what exactly is the best way forward to fix
> this issue in this patchset? Should I be managing a local mutex instead?

I think adding a local mutex for audio stuff would be best, if it's not
too hard.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]