Re: [PATCH v5 00/12] *** A Method for evaluating dirty page rate ***

[no-reply]

Patchew URL: 
1598260480-64862-1-git-send-email-zhengchuan@huawei.com/">https://patchew.org/QEMU/1598260480-64862-1-git-send-email-zhengchuan@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1598260480-64862-1-git-send-email-zhengchuan@huawei.com
Subject: [PATCH v5 00/12] *** A Method for evaluating dirty page rate ***

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   dd8014e..df82aa7  master     -> master
 - [tag update]      patchew/20200727112307.343608-1-Filip.Bozuta@syrmia.com -> 
patchew/20200727112307.343608-1-Filip.Bozuta@syrmia.com
 - [tag update]      
patchew/20200815013145.539409-1-richard.henderson@linaro.org -> 
patchew/20200815013145.539409-1-richard.henderson@linaro.org
 - [tag update]      patchew/20200822212129.97758-1-r.bolshakov@yadro.com -> 
patchew/20200822212129.97758-1-r.bolshakov@yadro.com
 - [tag update]      patchew/20200823083215.14952-1-thuth@redhat.com -> 
patchew/20200823083215.14952-1-thuth@redhat.com
 - [tag update]      patchew/20200823090546.47957-1-r.bolshakov@yadro.com -> 
patchew/20200823090546.47957-1-r.bolshakov@yadro.com
 - [tag update]      patchew/20200824074057.3673-1-kraxel@redhat.com -> 
patchew/20200824074057.3673-1-kraxel@redhat.com
 - [tag update]      patchew/20200824094811.15439-1-peter.maydell@linaro.org -> 
patchew/20200824094811.15439-1-peter.maydell@linaro.org
 - [tag update]      patchew/20200824100041.1864420-1-edgar.iglesias@gmail.com 
-> patchew/20200824100041.1864420-1-edgar.iglesias@gmail.com
 * [new tag]         patchew/20200824142934.20850-1-peter.maydell@linaro.org -> 
patchew/20200824142934.20850-1-peter.maydell@linaro.org
 * [new tag]         patchew/20200824152430.1844159-1-laurent@vivier.eu -> 
patchew/20200824152430.1844159-1-laurent@vivier.eu
 * [new tag]         patchew/20200824155111.789466-1-brogers@suse.com -> 
patchew/20200824155111.789466-1-brogers@suse.com
 * [new tag]         patchew/20200824155212.789568-1-brogers@suse.com -> 
patchew/20200824155212.789568-1-brogers@suse.com
 * [new tag]         patchew/20200824155236.789635-1-brogers@suse.com -> 
patchew/20200824155236.789635-1-brogers@suse.com
 * [new tag]         patchew/20200824161014.401882-1-ckuehl@redhat.com -> 
patchew/20200824161014.401882-1-ckuehl@redhat.com
 * [new tag]         patchew/20200824163109.96938-1-berrange@redhat.com -> 
patchew/20200824163109.96938-1-berrange@redhat.com
Switched to a new branch 'test'
e422c48 migration/dirtyrate: Add trace_calls to make it easier to debug
d544358 migration/dirtyrate: Implement 
qmp_cal_dirty_rate()/qmp_get_dirty_rate() function
b245e3e migration/dirtyrate: Implement calculate_dirtyrate() function
f634d60 migration/dirtyrate: Implement get_sample_page_period() and 
block_sample_page_period()
039884c migration/dirtyrate: skip sampling ramblock with size below 
MIN_RAMBLOCK_SIZE
b62b0f3 migration/dirtyrate: Compare page hash results for recorded sampled page
a0c77f6 migration/dirtyrate: Record hash results for each sampled page
7e4c941 migration/dirtyrate: move RAMBLOCK_FOREACH_MIGRATABLE into ram.h
5bd531b migration/dirtyrate: Add dirtyrate statistics series functions
af4f569 migration/dirtyrate: Add RamlockDirtyInfo to store sampled page info
9d2abe8 migration/dirtyrate: add DirtyRateStatus to denote calculation status
9da875e migration/dirtyrate: setup up query-dirtyrate framwork

=== OUTPUT BEGIN ===
1/12 Checking commit 9da875ef425e (migration/dirtyrate: setup up 
query-dirtyrate framwork)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 78 lines checked

Patch 1/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/12 Checking commit 9d2abe8b480a (migration/dirtyrate: add DirtyRateStatus to 
denote calculation status)
3/12 Checking commit af4f56975987 (migration/dirtyrate: Add RamlockDirtyInfo to 
store sampled page info)
4/12 Checking commit 5bd531bb00ce (migration/dirtyrate: Add dirtyrate 
statistics series functions)
5/12 Checking commit 7e4c941b32bc (migration/dirtyrate: move 
RAMBLOCK_FOREACH_MIGRATABLE into ram.h)
ERROR: Macros with multiple statements should be enclosed in a do - while loop
#62: FILE: migration/ram.h:42:
+#define RAMBLOCK_FOREACH_NOT_IGNORED(block)            \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (ramblock_is_ignored(block)) {} else

ERROR: trailing statements should be on next line
#64: FILE: migration/ram.h:44:
+        if (ramblock_is_ignored(block)) {} else

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#66: FILE: migration/ram.h:46:
+#define RAMBLOCK_FOREACH_MIGRATABLE(block)             \
+    INTERNAL_RAMBLOCK_FOREACH(block)                   \
+        if (!qemu_ram_is_migratable(block)) {} else

ERROR: trailing statements should be on next line
#68: FILE: migration/ram.h:48:
+        if (!qemu_ram_is_migratable(block)) {} else

ERROR: braces {} are necessary for all arms of this statement
#68: FILE: migration/ram.h:48:
+        if (!qemu_ram_is_migratable(block)) {} else
[...]
+        if (!qemu_ram_is_migratable(block)) {} else
[...]

total: 5 errors, 0 warnings, 45 lines checked

Patch 5/12 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/12 Checking commit a0c77f6034fc (migration/dirtyrate: Record hash results for 
each sampled page)
7/12 Checking commit b62b0f3c7033 (migration/dirtyrate: Compare page hash 
results for recorded sampled page)
8/12 Checking commit 039884cf410e (migration/dirtyrate: skip sampling ramblock 
with size below MIN_RAMBLOCK_SIZE)
9/12 Checking commit f634d60df875 (migration/dirtyrate: Implement 
get_sample_page_period() and block_sample_page_period())
10/12 Checking commit b245e3e9cd0d (migration/dirtyrate: Implement 
calculate_dirtyrate() function)
11/12 Checking commit d544358ff2b0 (migration/dirtyrate: Implement 
qmp_cal_dirty_rate()/qmp_get_dirty_rate() function)
12/12 Checking commit e422c48502c8 (migration/dirtyrate: Add trace_calls to 
make it easier to debug)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1598260480-64862-1-git-send-email-zhengchuan@huawei.com/testing.checkpatch/?type=message">http://patchew.org/logs/1598260480-64862-1-git-send-email-zhengchuan@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com