qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] configure: default to PIE disabled on Windows platforms


From: Marc-André Lureau
Subject: Re: [PATCH] configure: default to PIE disabled on Windows platforms
Date: Mon, 24 Aug 2020 21:36:39 +0400

Hi

On Mon, Aug 24, 2020 at 8:31 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
If Windows EXE files are built with -pie/-fpie they will fail to
launch. Historically QEMU defaulted to disabling PIE for Windows,
but this setting was accidentally lost when the configure summary
text was removed in

  commit f9332757898a764d85e19d339ec421236e885b68
  Author: Paolo Bonzini <pbonzini@redhat.com>
  Date:   Mon Feb 3 13:28:38 2020 +0100

    meson: move summary to meson.build

    Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Fixes: f9332757898a764d85e19d339ec421236e885b68
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>

(one of those innocent looking commits)

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>

---
 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index 67832e3bab..b6f3b6e191 100755
--- a/configure
+++ b/configure
@@ -857,6 +857,7 @@ MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  pie="no"
 ;;
 GNU/kFreeBSD)
   bsd="yes"
--
2.26.2




--
Marc-André Lureau

reply via email to

[Prev in Thread] Current Thread [Next in Thread]