Re: [PATCH v2 19/58] hvf: Move HVFState typedef to hvf.h

[Eduardo Habkost]

On Fri, Aug 21, 2020 at 02:23:55PM +0300, Roman Bolshakov wrote:
> On Wed, Aug 19, 2020 at 08:11:57PM -0400, Eduardo Habkost wrote:
> > Move typedef closer to the type check macros, to make it easier
> > to convert the code to OBJECT_DEFINE_TYPE() in the future.
> > 
> > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Changes v1 -> v2: none
> > 
> > ---
> > Cc: Cameron Esfahani <dirty@apple.com>
> > Cc: Roman Bolshakov <r.bolshakov@yadro.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Richard Henderson <rth@twiddle.net>
> > Cc: Eduardo Habkost <ehabkost@redhat.com>
> > Cc: qemu-devel@nongnu.org
> > ---
> >  include/sysemu/hvf.h       | 1 +
> >  target/i386/hvf/hvf-i386.h | 4 ++--
> >  2 files changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/include/sysemu/hvf.h b/include/sysemu/hvf.h
> > index d3bed80ea8..760d6c79a2 100644
> > --- a/include/sysemu/hvf.h
> > +++ b/include/sysemu/hvf.h
> > @@ -35,6 +35,7 @@ void hvf_vcpu_destroy(CPUState *);
> >  
> >  #define TYPE_HVF_ACCEL ACCEL_CLASS_NAME("hvf")
> >  
> > +typedef struct HVFState HVFState;
> 
> Forward declaration of HVFState is missed before the typedef.

Why is that an issue?

-- 
Eduardo