Re: [PATCH v2 54/58] [semi-automated] Use DECLARE_*CHECKER* when possible (--force mode)

[Daniel P . Berrangé]

On Wed, Aug 19, 2020 at 08:12:32PM -0400, Eduardo Habkost wrote:
> Separate run of the TypeCheckMacro converter using the --force
> flag, for the cases where typedefs weren't found in the same
> header nor in typedefs.h.
> 
> Generated initially using:
> 
>  $ ./scripts/codeconverter/converter.py --force -i \
>    --pattern=TypeCheckMacro $(git grep -l '' -- '*.[ch]')
> 
> Then each case was manually reviewed, and a comment was added
> indicating what's unusual about those type checking
> macros/functions.  Despite not following the usual pattern, the
> changes in this patch were found to be safe.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Changes v1 -> v2:
> * Most of the old changes in this patch are now being handled by
>   the regular TypeCheckMacro patch (without --force mode)
> * Added comments added explaining why these unusual changes
>   remain
> ---
>  include/hw/intc/arm_gic.h       | 9 +++------
>  include/hw/intc/arm_gicv3.h     | 8 +++-----
>  include/hw/ppc/xics_spapr.h     | 4 +++-
>  include/hw/virtio/virtio-mmio.h | 9 +++------
>  hw/intc/apic.c                  | 5 +++--
>  hw/intc/arm_gic_kvm.c           | 9 +++------
>  hw/intc/arm_gicv3_its_kvm.c     | 8 +++-----
>  hw/intc/arm_gicv3_kvm.c         | 9 +++------
>  hw/sd/allwinner-sdhost.c        | 5 +++--
>  hw/sd/bcm2835_sdhost.c          | 5 +++--
>  hw/sd/pxa2xx_mmci.c             | 4 +++-
>  hw/sd/sdhci.c                   | 4 +++-
>  12 files changed, 36 insertions(+), 43 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|