Re: [PATCH 4/5] meson: !/bin/sh are msys2 friendly.

[Eric Blake]

On 8/25/20 4:11 AM, 罗勇刚(Yonggang Luo) wrote:
> Hi, works, msys2 sh compiled and run

Top-formatting makes it harder to read, compared to interleaving your 
responses.

msys2 sh _is_ bash, so that's not answering the question Dan asked.


> > > +++ b/scripts/undefsym.sh
> > > @@ -1,4 +1,4 @@
> > > -#! /usr/bin/env bash
> > > +#!/bin/sh
> >
> > Does this script actually work on non-bash shells ?  If not, then this
> > change will likely break on plaforms where /bin/sh is not bash.

A quick look at the script sees:

comm -12 \
  <( $NM -P -g $staticlib | awk '$2!="U"{print "-Wl,-u," $1}' | sort -u) \
  <( $NM -P -g "$@" | awk '$2=="U"{print "-Wl,-u," $1}' | sort -u)


<() is a bash'ism, so you _are_ breaking things on platforms like Debian 
where /bin/sh is dash rather than bash.


--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org