Re: [RFC PATCH v3 02/34] Hexagon (target/hexagon) README

[Richard Henderson]

On 8/18/20 8:50 AM, Taylor Simpson wrote:
> +    #ifdef fGEN_TCG_A2_add
> +    fGEN_TCG_A2_add({ RdV=RsV+RtV;});
> +    #else
> +    do {
> +    gen_helper_A2_add(RdV, cpu_env, RsV, RtV);
> +    } while (0);

I don't understand the benefit of passing the SHORTCODE to fGEN_TCG_*.  Is this
file included for helper generation?

It seems to contradict what you have a few lines lower


> +The gen_tcg.h file has any overrides. For example,
> +    #define fGEN_TCG_A2_add(GENHLPR, SHORTCODE) \
> +        tcg_gen_add_tl(RdV, RsV, RtV)

which has two arguments not one.

Is this README out of date?


r~