Re: [PATCH 11/12] vnc-auth-sasl: Plug memleak in vnc_socket_ip_addr_string

[Li Qiang]

Pan Nengyuan <pannengyuan@huawei.com> 于2020年8月14日周五 下午6:40写道：
>
> 'addr' forgot to free in vnc_socket_ip_addr_string error path. Fix that.

s/forgot/is forgot, I think the maintainer will do this minor adjustment.

.



>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>

Reviewed-by: Li Qiang <liq3ea@gmail.com>

> ---
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  ui/vnc-auth-sasl.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c
> index 7b2b09f242..0517b2ead9 100644
> --- a/ui/vnc-auth-sasl.c
> +++ b/ui/vnc-auth-sasl.c
> @@ -522,6 +522,7 @@ vnc_socket_ip_addr_string(QIOChannelSocket *ioc,
>
>      if (addr->type != SOCKET_ADDRESS_TYPE_INET) {
>          error_setg(errp, "Not an inet socket type");
> +        qapi_free_SocketAddress(addr);
>          return NULL;
>      }
>      ret = g_strdup_printf("%s;%s", addr->u.inet.host, addr->u.inet.port);
> --
> 2.18.2
>
>