[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_mi
From: |
Li Qiang |
Subject: |
Re: [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features |
Date: |
Wed, 26 Aug 2020 20:25:24 +0800 |
Pan Nengyuan <pannengyuan@huawei.com> 于2020年8月14日周五 下午6:38写道:
>
> 'err' forgot to free in x86_cpu_class_check_missing_features error path.
> Fix that.
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Pan Nengyuan <pannengyuan@huawei.com>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
> ---
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Richard Henderson <rth@twiddle.net>
> Cc: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target/i386/cpu.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index 588f32e136..4678aac0b4 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -4872,6 +4872,7 @@ static void
> x86_cpu_class_check_missing_features(X86CPUClass *xcc,
> new->value = g_strdup("type");
> *next = new;
> next = &new->next;
> + error_free(err);
> }
>
> x86_cpu_filter_features(xc, false);
> --
> 2.18.2
>
>
- Re: [PATCH 05/12] target/i386/sev: Plug memleak in sev_read_file_base64, (continued)
- [PATCH 01/12] qga/channel-posix: Plug memory leak in ga_channel_write_all(), Pan Nengyuan, 2020/08/14
- [PATCH 06/12] ui/gtk-gl-area: Plug memleak in gd_gl_area_create_context(), Pan Nengyuan, 2020/08/14
- [PATCH 08/12] migration/colo: Plug memleaks in colo_process_incoming_thread, Pan Nengyuan, 2020/08/14
- [PATCH 09/12] blockdev: Fix a memleak in drive_backup_prepare(), Pan Nengyuan, 2020/08/14
- [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features, Pan Nengyuan, 2020/08/14
- Re: [PATCH 07/12] target/i386/cpu: Fix memleak in x86_cpu_class_check_missing_features,
Li Qiang <=
- [PATCH 04/12] elf2dmp/pdb: Plug memleak in pdb_init_from_file, Pan Nengyuan, 2020/08/14
- [PATCH 02/12] hw/vfio/ap: Plug memleak in vfio_ap_get_group(), Pan Nengyuan, 2020/08/14
- [PATCH 12/12] test-util-sockets: Fix a memleak in test_socket_unix_abstract_good, Pan Nengyuan, 2020/08/14