[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v3 12/34] Hexagon (target/hexagon) instruction attributes
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC PATCH v3 12/34] Hexagon (target/hexagon) instruction attributes |
|
Date: |
Wed, 26 Aug 2020 07:34:26 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 8/18/20 8:50 AM, Taylor Simpson wrote:
> +#define ATTRIB_WIDTH 32
> +#define GET_ATTRIB(opcode, attrib) \
> + (((opcode_attribs[opcode][attrib / ATTRIB_WIDTH])\
> + >> (attrib % ATTRIB_WIDTH)) & 0x1)
Can you define GET_ATTRIB in terms of qemu/bitops.h?
I'm leery of ATTRIB_WIDTH being separate from the actual definition of
opcode_attribs, over in opcodes.h.
Why does attribs.h need to live separately? They're clearly closely related,
and cannot in fact be used separately.
r~
- Re: [RFC PATCH v3 17/34] Hexagon (target/hexagon/imported) arch import - macro definitions, (continued)
- [RFC PATCH v3 23/34] Hexagon (target/hexagon) generater phase 4 - decode tree, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 09/34] Hexagon (target/hexagon) architecture types, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 16/34] Hexagon (target/hexagon) utility functions, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 12/34] Hexagon (target/hexagon) instruction attributes, Taylor Simpson, 2020/08/18
- Re: [RFC PATCH v3 12/34] Hexagon (target/hexagon) instruction attributes,
Richard Henderson <=
- [RFC PATCH v3 34/34] Hexagon build infrastructure, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 31/34] Hexagon (target/hexagon) translation, Taylor Simpson, 2020/08/18
- [RFC PATCH v3 26/34] Hexagon (target/hexagon) macros referenced in instruction semantics, Taylor Simpson, 2020/08/18