Re: [PULL 00/18] Usb 20200826 patches

[Peter Maydell]

On Wed, 26 Aug 2020 at 15:57, Gerd Hoffmann <kraxel@redhat.com> wrote:
>
> The following changes since commit d1a2b51f868d09ca8489ee9aee9c55632ed8fb92:
>
>   Merge remote-tracking branch 'remotes/berrange/tags/socket-next-pull-reques=
> t' into staging (2020-08-25 15:01:43 +0100)
>
> are available in the Git repository at:
>
>   git://git.kraxel.org/qemu tags/usb-20200826-pull-request
>
> for you to fetch changes up to 0cb60cbaf4831d859134eea39ae99ae23db79d9d:
>
>   usb: fix setup_len init (CVE-2020-14364) (2020-08-26 14:42:00 +0200)
>
> ----------------------------------------------------------------
> usb: usb_packet_map fixes for ehci and xhci.
> usb: u2f key support (GSoC).
> usb: setup_len fix (CVE-2020-14364).
>
>
> C=C3=A9sar Belley (12):

Something has mangled the UTF-8 in César's name here, though
it looks like it's OK in the git commits.

Anyway, format string issue on 32-bit:

../../hw/usb/u2f-passthru.c: In function 'u2f_passthru_recv_from_guest':
../../hw/usb/u2f-passthru.c:348:53: error: format '%lx' expects
argument of type 'long unsigned int', but argument 3 has type
'unsigned int' [-Werror=format=]
         error_report("%s: Bad written size (req 0x%lx, val 0x%lx)",
                                                   ~~^
                                                   %x
../../hw/usb/u2f-passthru.c:348:64: error: format '%lx' expects
argument of type 'long unsigned int', but argument 4 has type 'ssize_t
{aka int}' [-Werror=format=]
         error_report("%s: Bad written size (req 0x%lx, val 0x%lx)",
                                                              ~~^
                                                              %x

thanks
-- PMM